Guide: Use small size button for page controls #66607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
mirka
commented
Oct 30, 2024
| @@ -34,15 +34,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| &__container { | |||
There was a problem hiding this comment.
Fixing these to make the classes searchable.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 30, 2024
|
Flaky tests detected in ccb3a71. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11596977098
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Guide: Use small size button for page controls * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #65751
What?
Use
smallsize Buttons in the page controls for the Guide component.Why?
How?
Testing Instructions
See Storybook for Guide. In the block editor, open the Options menu in the top right and open the Welcome Guide.
Screenshots or screencast
@WordPress/gutenberg-design With the standard component sizing without overrides, you can see the page controls dots are a bit more spread out (Figma specs). I think this is acceptable, especially because it has more tappable surface area. Are we good with this?