Query block: remove incorrect selector call #66581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -53 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d366821. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11598535863
|
ellatrix
force-pushed
the
remove/incorrect-selector-call
branch
from
f208185
to
d366821
Compare
|
Fixed in #65820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
__experimentalGetTemplateForLinkrequires a first argument (the link) to work. Without the link argument the resolver will fail. The only reason this returns anything right now is because__experimentalGetTemplateForLinkhas already been called, and the resolver already triggered.linkargument, this selector essentially test if we're in the Site Editor or not. The Site Editor is the only place where__experimentalGetTemplateForLinkwill ever (and always) return a result without an argument.null.postTypeorpostIdfrom the context. See here and here. That check is already here, so this code actually seems to be checking for the Site Editor twice?Why?
Remove an incorrect call, which in turn causes an incorrect request (
/wp-admin/site-editor.php?_wp-find-template=true).How?
Remove it.
Testing Instructions
It was originally added in https://github.com/WordPress/gutenberg/pull/65067/files#r1821498758, so I assume the same testing instructions:
Testing Instructions for Keyboard
Screenshots or screencast