Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Oct 29, 2024

What?

Follow up to:

#66468 will be cherry picked to 6.7 since it's a regression.

Why?

Given that this fixes a 6.7 regression move the code into 6.7 compat.

How?

Copy paste

Testing Instructions

Fire up this branch and head to the site editor.

Check that global-styles endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_request

Do the same for the post editor.

Screenshots or screencast

@ramonjd ramonjd self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Type] Regression, Global Styles, Backport from WordPress Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Oct 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Type] Performance Related to performance efforts [Type] Regression Related to a regression in the latest release and removed [Type] Performance Related to performance efforts labels Oct 29, 2024
ramonjd added a commit that referenced this pull request Oct 29, 2024
@@ -1,3 +1,4 @@
https://github.com/WordPress/wordpress-develop/pull/7661

* https://github.com/WordPress/gutenberg/pull/66468
* https://github.com/WordPress/gutenberg/pull/66543
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need moving to the 6.7 backport-changelog folder too.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up, this is testing well for me!

Looks like the only change is $stylesheet being renamed to $active_theme 👍

Once the backport .md file is moved to 6.7, this looks good to land to me!

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Global styles paths are still preloaded correctly.

🚢

@ramonjd
Copy link
Member Author

ramonjd commented Oct 29, 2024

Thanks for the quick reviews, folks!

@ramonjd ramonjd enabled auto-merge (squash) October 29, 2024 02:16
@ramonjd ramonjd merged commit dc4bd05 into trunk Oct 29, 2024
64 checks passed
@ramonjd ramonjd deleted the update/move-global-styles-preload-from-6.8-to-6.7 branch October 29, 2024 02:45
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 29, 2024
ramonjd added a commit that referenced this pull request Oct 29, 2024
…tyles (#66468) (#66542)

* Sync with #66543
* Move backport log to 6.7

---------

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
ramonjd added a commit that referenced this pull request Oct 30, 2024
ramonjd added a commit that referenced this pull request Oct 30, 2024
ramonjd added a commit that referenced this pull request Oct 30, 2024
ramonjd added a commit that referenced this pull request Oct 30, 2024
@cbravobernal cbravobernal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Oct 30, 2024
peterwilsoncc pushed a commit to peterwilsoncc/gutenberg-build that referenced this pull request Oct 30, 2024
…tyles (#66468) (#66542)

* Sync with WordPress/gutenberg#66543
* Move backport log to 6.7

---------

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

Source: WordPress/gutenberg@cf008a0
ramonjd added a commit that referenced this pull request Oct 31, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
…dPress#66543)

* Given that this fixes a 6.7 regression move the code into 6.7 compat.

* Move for loop into context block

* Move backport log to 6.7

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants