-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global styles: move preload paths filter to 6.7 (previously 6.8) #66543
Global styles: move preload paths filter to 6.7 (previously 6.8) #66543
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -1,3 +1,4 @@ | |||
https://github.com/WordPress/wordpress-develop/pull/7661 | |||
|
|||
* https://github.com/WordPress/gutenberg/pull/66468 | |||
* https://github.com/WordPress/gutenberg/pull/66543 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might need moving to the 6.7 backport-changelog folder too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up, this is testing well for me!
Looks like the only change is $stylesheet
being renamed to $active_theme
👍
Once the backport .md
file is moved to 6.7, this looks good to land to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Global styles paths are still preloaded correctly.
🚢
Thanks for the quick reviews, folks! |
…tyles (#66468) (#66542) * Sync with #66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
…n post editor. Sync with #66543
…n post editor. Sync with #66543 Update comment
…tyles (#66468) (#66542) * Sync with WordPress/gutenberg#66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Source: WordPress/gutenberg@cf008a0
…n post editor. Sync with #66543 Update comment
…dPress#66543) * Given that this fixes a 6.7 regression move the code into 6.7 compat. * Move for loop into context block * Move backport log to 6.7 Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
What?
Follow up to:
#66468 will be cherry picked to 6.7 since it's a regression.
Why?
Given that this fixes a 6.7 regression move the code into 6.7 compat.
How?
Copy paste
Testing Instructions
Fire up this branch and head to the site editor.
Check that global-styles endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_request
Do the same for the post editor.
Screenshots or screencast