Inline commenting - Change new comment input option to use Textareacontrol#66391
Inline commenting - Change new comment input option to use Textareacontrol#66391hbhalodia wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Could you make it expand to the contents? I believe there's a component for it somewhere that we use. |
|
I think that would be |
I think we need to use something like this, https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/plain-text/README.md but not sure, I tried this, but looks like we need more styling to add make it look like a component, but I guess this is what need here.
|
You're right. |
|
Yes, we shouldn't use PlainText, it's meant for blocks. Let's stick with a textarea that autoresizes for now :) |
Yes, thanks @ellatrix, for the confirmation. |
|
This was already changed in 930dfa5
That still remains I believe |
@Mamaduka - I tried this in #71424. I had to remove some props that were throwing errors and realize we need to add some sort of default height to the element. Is there a specific class appropriate for that here? |
|
This was resolved via #71424. |

Partof - #66377
What?
TextcontroltoTextareacontrolto add the new comments.Why?
How?
Textareacontrol.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast