Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border support added to comments #66354

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rinkalpagdar
Copy link
Contributor

@rinkalpagdar rinkalpagdar commented Oct 23, 2024

What?

Add border block support to the Comments block.
Part of #43247

Why?

Comments block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

Testing Instructions for Keyboard

  1. Go to the Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  2. Make sure that the Comments block's border is configurable via Global Styles
  3. Verify that Global Styles are applied correctly in the editor and frontend
  4. Edit the template/page, Add Comments block and Apply the border styles
  5. Verify that block styles take precedence over global styles
  6. Verify that block borders display correctly in both the editor and frontend

Screenshots or screencast

comments-border

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 23, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rinkalpagdar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@carolinan carolinan added [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement. labels Oct 23, 2024
Copy link
Contributor

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @rinkalpagdar ! 🙏

This tests well for me both on the frontend and in the editor.

@michalczaplinski michalczaplinski merged commit 0faf4c5 into WordPress:trunk Oct 24, 2024
67 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 24, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
* Border support added to comments

* css lint fix

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants