-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Activate zoom out on large viewport #66308
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR 👍
To test this accurately I needed to set my viewport to around 587px
. Is that right?
Here's what I saw
Before (trunk)
After (this branch)
Once this is merged we'll need a similar fix targeting wp/6.7
branch. Let's wait for this one to merge before we tackle that though so as not to duplicate effort.
Thanks again for your contribution here 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@getdave Does this PR need a backport label? Is it okay to merge it as is, since the automatic cherry-pick will probably fail?
Either way, I think we need a separate PR for wp/6.7
.
Merged trunk to fix lint errors. See #66316. |
Just to be safe, I will remove the backport label before merging. I will create a PR for WP 6.7 now. |
@t-hamano Yes let's do a manual backport and then add to the 6.7 board for review. Thanks |
Manual backport in #66330 |
I don't think this is the fix we want. I think the viewport check should be passed into the |
* Activate zoom out on large viewport * Reset zoom out when view-port change to medium --------- Co-authored-by: PARTHVATALIYA <parthvataliya@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
What?
Solve #66205
Why?
Part of #66205
Testing Instructions