Wrap overflow: auto in media query for smaller screens only #66176
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses #66161 and #66156
Why?
The appearance of double vertical scrollbars was occurring in certain instances of the interface where the viewport height was small. It seemed to be triggered by the
overflow: auto
, which had a previous code comment indicating that theoverflow: auto
was implemented to circumvent issues with mobile Safari. Based on the commentary it seems we would want theoverflow: auto
to only impact smaller horizontal screens and not smaller vertical screens.How?
By wrapping the
overflow: auto
in a media query:@media (max-width: #{ ($break-medium - 1) })
we make sure the overflow is only applied to smaller horizontal screens.Testing Instructions
The original bug reported in #66161 impacts small vertical screens.
Screenshots or screencast
double-scrollbar-before.mp4
double-scrollbar-after.mp4