-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combobox/add custom element when suggestions not found #66142
Open
vykes-mac
wants to merge
8
commits into
WordPress:trunk
Choose a base branch
from
vykes-mac:combobox/add-custom-element-when-suggestions-not-found
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bfb3f06
add experimental prop for rendering a custom component when no sugges…
vykes-mac 7037c79
render custom no suggestion found element if provided and suggestions…
vykes-mac e945b6e
add storybook example
vykes-mac c824183
update readme file with prop
vykes-mac e12aec4
add changelog entry
vykes-mac 0bc3703
remove extra prop and always show the items not found copy
vykes-mac 16ca239
update changelog
vykes-mac edb25fd
remove the extra prop
vykes-mac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ import type { MouseEventHandler, ReactNode } from 'react'; | |
* WordPress dependencies | ||
*/ | ||
import { useRefEffect } from '@wordpress/compose'; | ||
import { __ } from '@wordpress/i18n'; | ||
|
||
/** | ||
* Internal dependencies | ||
|
@@ -156,6 +157,11 @@ export function SuggestionsList< | |
); | ||
/* eslint-enable jsx-a11y/click-events-have-key-events */ | ||
} ) } | ||
{ suggestions.length === 0 && ( | ||
<li className="components-form-token-field__suggestion is-empty"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Were you planning on styling the &:not(.is-empty) {
cursor: pointer;
} |
||
{ __( 'No items found' ) } | ||
</li> | ||
) } | ||
</ul> | ||
); | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this also affects the
FormTokenField
component when the__experimentalExpandOnFocus
prop is enabled.