Use proper named File when uploading external images
#65693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +40 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Thank you for the PR, @swissspidy! 🙌
I tested this from the media tab in the editor, and it does work as intended. In the case of stocksnap.io images, the names could be more meaningful if we were using the image URL (https://cdn.stocksnap.io/img-thumbs/960w/fruit-vegetables_F8B73CPSBK.jpg) instead of the thumbnail URL (https://cdn.stocksnap.io/img-thumbs/960w/F8B73CPSBK.jpg), which seems to be the case at the moment. That said, even if we want to improve that, it would probably best be done in a different PR.
sgomes
reviewed
Sep 27, 2024
| @@ -167,8 +168,13 @@ export function MediaPreview( { media, onClick, category } ) { | |||
| .fetch( url ) | |||
| .then( ( response ) => response.blob() ) | |||
| .then( ( blob ) => { | |||
| const fileName = getFilename( url ) || 'image.jpg'; | |||
There was a problem hiding this comment.
Note for other reviewers: the fallback uses .jpg regardless of the actual file type, since we rely on the server to choose an appropriate file extension for us. We do need to provide some image-related file extension, however, even if it's wrong, otherwise the server will outright reject the upload.
Do we even have access to the full URL in this component? Maybe from the |
No, the Edit: the thumbnail URL seems to be all we get from the OpenVerse API: |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ress#65693)" This reverts commit 0301198.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When uploading an Openverse image, the image won't have a name because we are just uploading a
Blobinstead of aFileas expected bymediaUpload(). The browser will then default to something likeimage.jpg.This changes that.
Why?
We should use a proper
Fileobject with an actual image name so that you don't have dozens ofimage-x.jpgfiles in the media library.A similar change was recently done in #65122.
How?
Uses
getFilenameto get an image name from a URL, only usingimage.jpgas a fallback.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast