Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post editor: fix meta boxes accessibility #65466

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Post editor: fix meta boxes accessibility #65466

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
30e93ed
Replace details element with custom toggle
stokesman Sep 18, 2024
0fb80be
Consolidate details of updating height into function
stokesman Sep 18, 2024
c95b5c9
Reduce conditionals for toggle vs. resizable
stokesman Sep 18, 2024
5b355f4
Fix style in RTL
stokesman Sep 21, 2024
ea1f96c
Remove unneeded overflow style
stokesman Sep 21, 2024
e39c22a
Maintain focus even with caret browsing on
stokesman Sep 23, 2024
56ae759
Use `ResizableBox` again
stokesman Sep 26, 2024
b7f087e
Add aria-expanded to toggle and remove aria-label
stokesman Sep 26, 2024
753edcf
Fix styles for Windows high contrast mode
stokesman Sep 26, 2024
9d25236
Add missing "border" in Windows high contrast mode
stokesman Sep 26, 2024
3f7553b
Move `flex-shrink` rule to toggle only
stokesman Sep 26, 2024
89fdd4e
Fix rule preserved for non-iframe canvas
stokesman Sep 26, 2024
4ad9319
Make meta boxes container a navigable region
stokesman Sep 27, 2024
097eb3c
Try hiding meta box region contents when not expanded
stokesman Sep 27, 2024
91ddb55
Fix hidden conditional
stokesman Sep 27, 2024
b1b0ad2
Rename a couple functions
stokesman Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add aria-expanded to toggle and remove aria-label
  • Loading branch information
@stokesman
stokesman committed Sep 26, 2024
commit b7f087ecb19759e681a5f7400b8edb0164bcb03d
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/layout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ function MetaBoxesMain( { isLegacy } ) {
<Pane aria-label={ paneLabel } { ...paneProps }>
{ isShort ? (
<button
aria-expanded={ isOpen }
className="edit-post-meta-boxes-main__presenter"
aria-label={ __( 'Expand or collapse meta boxes pane' ) }
onClick={ toggle }
>
{ paneLabel }
Expand Down