fix the issue where block spacing control not shown #65371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
the
[Type] Regression
|
Size Change: +42 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
vcanales
added
the
Backport to Gutenberg Minor Release
That seems like the wrong PR reference. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I can see the Block Spacing control again, but it doesn't seem to work—setting a value seems to make the gap 0; unsetting the value resets the gap to the default. Here's a comparison of this branch with 19.1, the version before the new control was introduced: Working, 19.1buttons-block-spacing-19-1.movThis branchbuttons-block-fix.mov |
Sorry about that. Updated with right PR number. |
@vcanales seems like the issue got introduced in #64971. 
Though both are related, I think this PR doesn't have to wait as it restores previous behaviour and #65306 is fixing it. @t-hamano what do you think? |
|
To be precise, #64971 did not introduce any new problems. #64971 only extended the Buttons block gap support, so if it caused a problem, it means that the problem was already potentially there. For example, the Social Icons block supports axis gaps, just like the Buttons block. You should be able to reproduce the same issue by defining a theme.json like the one below on a WP 6.6 without the Gutenberg plugin: {
"version": 3,
"settings": {
"appearanceTools": true,
"layout": {
"contentSize": "840px"
}
},
"styles": {
"blocks": {
"core/social-links" : {
"spacing": {
"blockGap": "1em"
}
}
}
}
}This means that this problem was at least potentially present as of WP 6.6. Therefore, I think this PR should focus on fixing the regression introduced in #65193. |
vcanales
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
@madhusudhand @t-hamano thanks for pointing me to the source of the issue I found. Yes, indeed, it looks like it's unrelated. In that case, this PR looks good.
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes issue where block spacing control is not shown when only one side is set.
It is a regression introduced in #65193
See this comment for more details on the issue.
Why?
It is because the function
getInitialViewis returning custom when a single side is set. Instead it should render single sided view.How?
Function is reverted to its original state (before #65193) and introduced an additional condition to check if the support for sides is axial only (i.e. horizontal and vertical only)
Testing Instructions
theme.jsonand UI should show the custom view (with all 4 side controls) and corresponding side value should be set.theme.jsonand it should show single custom control.Screenshots or screencast
when nothing set, or equal values are set for
top,bottomandleft,rightWhen custom values are set: