Fix Tabs styling in Font Library modal #65330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Looking at this usage example, is there anything that we can bring back to the |
If it isn't too much extra work, it might make sense to improve the logic so it considers that |
Agreed — @DaniGuardiola up to your judgment |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a regression in the tablist styling in the Font Library modal.
How?
The regression is likely due to the new focus indicator animations in Tabs not working well with the style overrides in Font Library modal. I changed the structure a bit so the style overrides are non-invasive.
Testing Instructions
To see the Font Library modal, go to Site Editor ▸ Global Styles ▸ Typography ▸ Manage Fonts.
Testing Instructions for Keyboard
Move the focus indicators with a keyboard.
Screenshots or screencast
For reference, this is what it looked like before it regressed: