Patterns: Change deprecated social icons for standard in e2e #65312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
the
[Feature] Patterns
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
added
the
[Type] Bug
kevin940726
reviewed
Sep 13, 2024
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Thanks for the quick fix! Let's see if all the E2E tests pass 👀 |
|
It looks like "cancels dragging patterns from the global inserter by pressing Escape" test also needs to be updated. |
Co-authored-by: Kai Hao <kevin830726@gmail.com>
cbravobernal
force-pushed
the
fix/pattern-e2e-test
branch
from
960bdae
to
b3d86b2
Compare
|
Updated a couple more, although I'm not sure of what those tests do 😓
|
|
You can update the snapshots by appending the |
|
I was just fixing that 😅 The tests passed locally. |
kevin940726
approved these changes
Sep 13, 2024
|
There are two standards in |
t-hamano
reviewed
Sep 13, 2024
Comment on lines
598
to
599
| name: 'core/social-links-shared-background-color', | ||
| title: 'Social links with a shared background color', | ||
| name: 'core/standard', | ||
| title: 'Standard', |
There was a problem hiding this comment.
A block pattern called "Standard" is already loaded here.
Perhaps we should just delete this object itself?
There was a problem hiding this comment.
Alternatively, it looks like this test isn't calling the core patterns, but is just preparing the patterns for testing. If we revert the changes in this file itself, does the test pass?
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Social links shared background color has been deprecated in Core: WordPress/wordpress-develop@a78540b
Why?
To fix CI.
How?
Using the standard pattern for testing.
Testing Instructions
e2e should pass.