-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator Screen: warn if path doesn't follow a URL-like scheme #65231
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ciampo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Add a runtime check in
NavigatorScreen
to warn consumers when thepath
prop doesn't follow the expected formatWhy?
When the expected format is not used,
Navigator
doesn't behave as expected (see, for example, #65109). A runtime check is one more way that we can help consumers ofNavigator
to use the component as expected.How?
If the
path
doesn't start with/
, output a warning to console.Testing Instructions
In dev mode, in the editor try changing the
path
of aNavigatorScreen
component and remove the leading/
— a warning should be printed to console.The new unit test should pass.