-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Button Replace remaining 40px default size violations [Block Editor 3] #65225
Changes from 1 commit
70ec0f7
631a42c
36d6a70
670cca8
913f90c
e7b1615
bb9545f
c452baa
c8c0e5d
00da47a
9d3d8ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -190,8 +190,7 @@ export default function FiltersPanel( { | |
return ( | ||
<ItemGroup isBordered isSeparated> | ||
<Button | ||
// TODO: Switch to `true` (40px size) if possible | ||
__next40pxDefaultSize={ false } | ||
__next40pxDefaultSize | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{ ...toggleProps } | ||
> | ||
<LabeledColorIndicator | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,6 @@ export function ShadowPopoverContainer( { shadow, onShadowChange, settings } ) { | |
/> | ||
<div className="block-editor-global-styles__clear-shadow"> | ||
<Button | ||
// TODO: Switch to `true` (40px size) if possible | ||
__next40pxDefaultSize={ false } | ||
variant="tertiary" | ||
onClick={ () => onShadowChange( undefined ) } | ||
|
@@ -89,8 +88,7 @@ export function ShadowIndicator( { type, label, isActive, onSelect, shadow } ) { | |
} ) } | ||
render={ | ||
<Button | ||
// TODO: Switch to `true` (40px size) if possible | ||
__next40pxDefaultSize={ false } | ||
__next40pxDefaultSize | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @WordPress/gutenberg-design ? Seems to me like we just want normal There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems that the Shadow Palette has used the I don't know why the In fact, the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For this PR it's probably best to keep those buttons visually looking the same as before, regardless of what component is used. A Longer term, we should find a better design for these that's clearer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to avoid the arbitrary There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also noticed that wrapping the ☝️ @ciampo Did you know about this quirk? Not immediately sure why that is. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I wasn't aware. Maybe we should open a separate issue to at least track this quirk There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @t-hamano I have updated There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the update. I think it perfectly maintains its functionality and style 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Documented the Composite + Tooltip issue at #65615. |
||
className={ clsx( | ||
'block-editor-global-styles__shadow-indicator', | ||
{ | ||
|
@@ -143,11 +141,7 @@ function renderShadowToggle() { | |
}; | ||
|
||
return ( | ||
<Button | ||
// TODO: Switch to `true` (40px size) if possible | ||
__next40pxDefaultSize={ false } | ||
{ ...toggleProps } | ||
> | ||
<Button __next40pxDefaultSize { ...toggleProps }> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<HStack justify="flex-start"> | ||
<Icon | ||
className="block-editor-global-styles__toggle-icon" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already taking 40px in height before, so there's no change after setting it to true.