-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Inserter: Fix pattern list overflow #65192
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +2 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the quick fix.
Fixes #65189
Follow-up #65115
What?
This PR fixes an issue where the pattern list could not be scrolled correctly when opened from the pattern inserter.
Why?
The following CSS is expected to make the
BlockPatternsList
scroll automatically if the content is long:gutenberg/packages/block-editor/src/components/inserter/style.scss
Lines 340 to 345 in 57e0b9c
However, it appears that this component was wrapped by the
VStack
component, causing unintended behavior.How?
There are probably a few different approaches we could take, but addingBased on this discussion, I removed theoverflow:hidden
to a VStack component seems like the easiest approach.VStack
component and applied a bottom padding to the text instead.Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4