-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences: Fix back button on mobile #65141
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +4 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before
2024-09-09.10.51.01.mp4
After
2024-09-09.10.52.24.mp4
Thanks for the quick review! |
Thanks for the quick fix 🙇♂️ |
Thanks for fixing and reviewing it so quickly, folks 🙌 |
What?
Fixes #65109
Fix the back button in the Preferences modal on mobile by ensuring that the paths use a
/
prefix. Kudos @t-hamano for investigating (#65109 (comment)) and getting to the bottom of the issue and finding a neat fix.Why?
It turns out that the backwards navigation requires a
/
in order to work properly. As Aki found in the issue, here is a comment making that concept explicit: https://github.com/WordPress/gutenberg/pull/63317/files#r1718790198Prior to this PR the back button in the preferences modal wasn't doing anything in mobile viewport sizes. With this PR applied, it should be fixed.
How?
/
prefixes to the paths used in the modal, for both the tabs and the navigation screen.Testing Instructions
Screenshots or screencast
Before
2024-09-06.16.17.26.mp4
After
2024-09-09.10.33.02.mp4