Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds max limit to row span and column span in grid. #64895

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

vipul0425
Copy link
Contributor

What?

Fixes: #63967

Why?

There was no maximum limit set for row span and column span, allowing users to set values larger than the actual number of rows or columns.

How?

It calculates the max column and row span based on the columns/row count and current position.

Testing Instructions

  1. Adds the grid block.
  2. Insert any block into it example image block.
  3. Try to increase/decrease the row/column span in the style tab of the block. It should not exceed the max columns/rows.

Screenshots or screencast

Screen.Recording.2024-08-29.at.2.31.25.PM.mov

Copy link

github-actions bot commented Aug 29, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Feature] Layout.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added the [Feature] Layout Layout block support, its UI controls, and style output. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid: Add max to 'Row span' and 'Column span' controls
2 participants