Improve Social Icons setup and appending #64877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
This comment was marked as resolved.
This comment was marked as resolved.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +409 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flipping this back to draft status until I'm confident in the keyboard implementation. |
jeryj
approved these changes
Aug 28, 2024
Mamaduka
reviewed
Aug 28, 2024
Mamaduka
reviewed
Aug 28, 2024
jeryj
reviewed
Aug 28, 2024
| templateLock: false, | ||
| orientation: attributes.layout?.orientation ?? 'horizontal', | ||
| __experimentalAppenderTagName: 'li', | ||
| renderAppender: hasAnySelected && InnerBlocks.ButtonBlockAppender, |
There was a problem hiding this comment.
There's a focus loss when pressing escape from the appender popover.
There was a problem hiding this comment.
Thanks. I'll take a look.
There was a problem hiding this comment.
I can't seem to replicate this...how do you do it?
How do you track focus? I'm using document.activeElement.
There was a problem hiding this comment.
- Navigate to the appender
- Press Enter
- Focus is within the popover
- Press Escape
- Focus is...? It should be visible and on the appender again since that's what opened the popover.
There was a problem hiding this comment.
Oh man. I missed the word "appender". My bad. I was looking at the URL popover 🤦
There was a problem hiding this comment.
I pushed a commit which aims to restore focus to the appender once the quick inserter is closed. LMK what you think 🙏
Fixed in #64883 |
@jeryj Looks like you have some feedback and suggestions there. Those would be outside the scope of this PR. AFAIK my PR does not make the keyboard navigability any worse so shall we merge here and iterate in your PR? |
Oh for sure. I was just logging things to note them that they were reviewed and matched on trunk. Not to suggest to fix them here. |
|
If we can figure out a way to get focus back to the appender when closing the popover, this will be ready to merge. |
I spent quite a while trying this morning. I've got to the stage where I"m considering stripping out the My current suspect is a parent component re-render is causing the element reference to change. |
|
Flaky tests detected in a1b2a22. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10618610579
|
|
Thanks for working on this, it works much better with keyboard ❤️ |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This was referenced Sep 25, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60120
What?
Improves the ability to add new social icons.
This will be nicely complemented by #59303.
Why?
Currently the initial and subsequent states of the Social Icons block(s) can make it very challenging to add new social links. This PR seeks to improve that.
How?
Click + to addinstruction. It was always a stop gap and provided a poor UX.Testing Instructions
Testing Instructions for Keyboard
My main concerns is how the focus move should work. I can use arrow keys to reach the appender but I'm not sure that resolves the problems in #60120.
I'll do some more digging on this as I'm not confident it's good enough yet.
Screenshots or screencast
Before
Screen.Capture.on.2024-08-28.at.16-07-03.mp4
After
Screen.Capture.on.2024-08-28.at.16-05-22.mp4