Add border to Replace item in content only image toolbar #64849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Enhancement
|
Size Change: +6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c0ceb58. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10584483425
|
MaggieCabrera
approved these changes
Aug 29, 2024
|
@jeryj do you mind resolving the conflict here? |
jeryj
force-pushed
the
update/add-replace-border
branch
from
c0ceb58
to
15bc1b6
Compare
jeryj
force-pushed
the
update/add-replace-border
branch
2 times, most recently
from
f5dd308
to
4de24d2
Compare
|
This needs a re-check, as trunk changed enough to mean I had to solve this in a new way. |
andrewserong
force-pushed
the
update/add-replace-border
branch
from
4de24d2
to
cfcfa02
Compare
andrewserong
approved these changes
Sep 16, 2024
This was referenced Sep 26, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #64727
What?
Adds border around Replace item in content only image
Closes #64727
Why?
From @richtabor:
How?
Places Replace in its own BlockControls group to have borders applied by default
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast