Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instances of deprecated elevation variables #64656

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Replace instances of deprecated elevation variables #64656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply elevation scale
  • Loading branch information
@jameskoster
jameskoster committed Aug 20, 2024
commit 9dc871d46178e546c52be22036dbd446b0600c21
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/inserter/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ $block-inserter-tabs-height: 44px;
.components-popover__content {
border: none;
outline: none;
box-shadow: $shadow-popover;
box-shadow: $elevation-x-small;

.block-editor-inserter__quick-inserter > * {
border-left: $border-width solid $gray-400;
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/url-input/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ $input-size: 300px;
}

.block-editor-url-input__button-modal {
box-shadow: $shadow-popover;
box-shadow: $elevation-x-small;
border: 1px solid $gray-300;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, just noticing. Should this be $border-width instead of 1px?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there a number of instances of such oversights 😓

Let's open a separate PR to address, hopefully it's a quick find & replace for this one.

background: $white;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
border: $border-width solid $gray-900;

&:hover {
box-shadow: $shadow-popover;
box-shadow: $elevation-x-small;
}

@include break-small() {
Expand Down
2 changes: 1 addition & 1 deletion packages/dataviews/src/components/dataviews-bulk-actions-toolbar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

.components-accessible-toolbar {
border-color: $gray-300;
box-shadow: $shadow-popover;
box-shadow: $elevation-x-small;

.components-toolbar-group {
border-color: $gray-200;
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-widgets/src/components/error-boundary/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
max-width: 780px;
padding: 20px;
margin-top: 60px;
box-shadow: $shadow-modal;
box-shadow: $elevation-large;
}
2 changes: 1 addition & 1 deletion packages/editor/src/components/error-boundary/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
max-width: 780px;
padding: 20px;
margin-top: 60px;
box-shadow: $shadow-modal;
box-shadow: $elevation-large;
}
Loading