Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextControl: Fix remaining 40px size violations #64594

Merged
merged 22 commits into from
Aug 19, 2024
Merged

TextControl: Fix remaining 40px size violations #64594

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
29fd789
Fix in DateFormatPicker
mirka Aug 16, 2024
6257d8d
Fix in ImageURLInputUI
mirka Aug 17, 2024
2b0b2d6
Fix in Button block
mirka Aug 17, 2024
8324c68
Fix in Form block InputFieldBlock
mirka Aug 17, 2024
29012b0
Fix in Form block
mirka Aug 17, 2024
4f207fe
Fix in Image block content only mode
mirka Aug 17, 2024
72388c0
Fix in Navigation block
mirka Aug 17, 2024
eeb5420
Fix in Post Comment block (deprecated)
mirka Aug 17, 2024
fd4c152
Fix in Featured Image block
mirka Aug 17, 2024
8f2a453
Fix in Categories block
mirka Aug 17, 2024
c88015e
Fix in Title block
mirka Aug 17, 2024
c1af253
Fix in Social Icons block
mirka Aug 17, 2024
27ebd82
Fix in Template Part block
mirka Aug 17, 2024
c84c59f
Fix in Video block track editor
mirka Aug 17, 2024
16d6568
Fix in Dataviews Add new view modal
mirka Aug 17, 2024
545f025
Fix in Dataviews Rename view modal
mirka Aug 17, 2024
53e6ec3
Fix in PostPublishPanel
mirka Aug 17, 2024
7b208b5
Fix in PostSlug component (unused in app)
mirka Aug 17, 2024
1dcb2c5
Fix in HierarchicalTermSelector
mirka Aug 17, 2024
e42dd71
Fix in ReusableBlockConvertButton (unused in app)
mirka Aug 17, 2024
6cfbf62
Move to stricter lint rule
mirka Aug 17, 2024
bc7ee44
Update snapshot
mirka Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix in Template Part block
  • Loading branch information
@mirka
mirka committed Aug 17, 2024
commit 27ebd82c838db2522cac9eb8a4088aa248c335e6
6 changes: 2 additions & 4 deletions packages/block-library/src/template-part/edit/advanced-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ export function TemplatePartAdvancedControls( {
{ isEntityAvailable && (
<>
<TextControl
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be seen when you select a template part block (like "Header") in the site editor.

Before After
Template Part block inspector, before Template Part block inspector, after

__nextHasNoMarginBottom
label={ __( 'Title' ) }
value={ title }
Expand All @@ -85,8 +84,7 @@ export function TemplatePartAdvancedControls( {
/>

<SelectControl
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
__nextHasNoMarginBottom
label={ __( 'Area' ) }
labelPosition="top"
Expand Down