Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background block supports: remove unused properties in unit tests #64564

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Aug 16, 2024

What? How? Why?

Rolling back changes to the background block support PHP unit tests in https://github.com/WordPress/gutenberg/pull/64328/files#diff-ce100b2b3e8a970bae81de825ea1897ec6b906a5dce500732b7aa4186fd34ff7R125 as the id does not affect the test and the code that is being tested does not take it into account at all.

The core backport is contained in WordPress/wordpress-develop#7137

Testing:

npm run test:unit:php:base -- --filter WP_Block_Supports_Background_Test

…4328/files#diff-ce100b2b3e8a970bae81de825ea1897ec6b906a5dce500732b7aa4186fd34ff7R125 as the id does not affect the test and the method that is being tested does not take it into account at all.
@ramonjd ramonjd added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Aug 16, 2024
@ramonjd ramonjd self-assigned this Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tests pass, and it looks like the id was not necessary for these ones 👍

@ramonjd ramonjd merged commit 6de3f66 into trunk Aug 16, 2024
67 of 68 checks passed
@ramonjd ramonjd deleted the remove/background-text-fixture-values branch August 16, 2024 01:57
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 16, 2024
@artemiomorales artemiomorales added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Automated Testing, Backport from WordPress Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@artemiomorales artemiomorales added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 21, 2024
@ramonjd ramonjd removed the [Type] Code Quality Issues or PRs that relate to code quality label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants