Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash Inserter: Restrict block list to allowed blocks only #64413

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ssang
Copy link
Contributor

@ssang ssang commented Aug 10, 2024

What?

Fixes #64411

This PR forces the WPCompleter block list to show insertable blocks only and fixes a regression introduced by #62169.

Why?

See #64411

#62169 enabled all blocks to be visible in the block list. The WPCompleter component should be restricted to relevant blocks like the QuickInserter

How?

afa0d6e added a isQuick parameter to the useBlockTypesState() call to restrict the quick inserter to a list of relevant blocks. Setting this to true when used in the WPCompleter component forces it to act like a QuickInsterter and only shows relevant blocks.

Testing Instructions

  1. Create a block that allows for a subset of blocks including the core/paragraph block as child blocks
  2. Insert the paragraph block
  3. Type / to start searching for other blocks

Screenshots or screencast

Before Gutenberg version 18.5.0

image

Gutenberg version ^18.5.0

image

@ssang ssang requested a review from ellatrix as a code owner August 10, 2024 07:20
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ssang.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: ssang.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ssang! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 10, 2024
@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Aug 11, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is working for me, and it seems like the intended use of the isQuick param.

Thanks again for spotting and fixing the bug.

@talldan talldan merged commit 6445ff1 into WordPress:trunk Aug 13, 2024
66 of 67 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 13, 2024
talldan added a commit that referenced this pull request Aug 13, 2024
Unlinked contributors: ssang.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
@talldan
Copy link
Contributor

talldan commented Aug 13, 2024

I've confirmed that the bug is also in WordPress 6.6.1, so I've cherry picked this onto the wp/6.6 branch for release in 6.6.2 - ac02098

@talldan talldan added the Backported to WP Core Pull request that has been successfully merged into WP Core label Aug 13, 2024
@talldan talldan changed the title WPCompleter: Restrict block list to allowed blocks only Slash Inserter: Restrict block list to allowed blocks only Aug 13, 2024
@ssang ssang deleted the fix/autocompleter-block-list branch August 13, 2024 16:13
@ssang
Copy link
Contributor Author

ssang commented Aug 13, 2024

Thanks for the quick turnaround. Glad to see it fast forwarded to 6.6.2.

I linked my account to WP if that affects anything. But that doesn't really matter :D

getdave pushed a commit that referenced this pull request Aug 14, 2024
Unlinked contributors: ssang.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default paragraph block ignoring allowedBlocks parameter when searching for blocks
3 participants