Fix: Data Views: bulk deleting causes a countdown experience in modal #64407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is intended to fix: #64405
Why?
When bulk deleting items, the loading state numbers should not be changed in the modal
How?
initialItemCount
is a ref that holds the initial number of items. The value of a ref persists across re-renders, so even ifitems.length
changes, initialItemCount.current will still hold the original number of items.Testing Instructions
Test on a site with at least 100+ pages. Here's a playground link that will spin up a version.
Open the Site Editor > Pages.
Switch to Grid layout.
Bulk edit and select all.
Move the items to trash.
Notice the modal counts down from 20.
Screenshots or screencast
Screen.Recording.2024-08-09.at.3.49.48.PM.mov