BlockDraggable: Remove invalid aria-hidden attribute from button#64228
Merged
BlockDraggable: Remove invalid aria-hidden attribute from button#64228
Conversation
t-hamano
added
[Type] Code Quality
t-hamano
force-pushed
the
quality/focusble-element-aria-hidden
branch
from
f45140f to
96da007
Compare
|
Size Change: -6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the following browser console error that occurs when interacting with a block drag handle with the mouse:
Note: I saw this warning in Google Chrome 127.0.6533.89, and I don't understand why it's only happening now, since this code has been around for several years 🤷♂️
StrictModeenabled in #61943 does not appear to be related to this issue.85f70ff16f733fb09c2fc65febc11ced.mp4
Why?
We should not apply
aria-hidden="true"to focusable elements.How?
Delete
aria-hidden="true". SincetabIndexis-1, we should not be able to tab to the drag handle as before.Testing Instructions