Inserter: Fade pattern previews in #63576
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] Blocked
|
Size Change: +85 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Coincidently I was trying a related thing yesterday. What I found was that In my case, I wanted to avoid rendering the pattern preview until it entered the viewport to see if it helped the ones already entered load more quickly. To make that work the pattern previews have to start with a |
Yep, passing a handler sounds like a good way to isolate any changes. Note that I don't mean to land this, not in the way it is, but I wanted to put it in a PR so it leaves a record. As discussed in the related issue, this doesn't solve the primary issue, and I'll be looking for a proper solution. In the meantime, we could add the fade in effect, because it can improve the appearance of the pattern previews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Crude experimentation to fade in pattern previews.
Please don't merge, this isn't production-ready.
Why?
Pattern previews loading is often slow and clunky.
See #44750
How?
Adding an extra prop and some a simple CSS opacity transition.
Testing Instructions
Open the pattern inserter and switch through some tabs.
Testing Instructions for Keyboard
None.
Screenshots or screencast
Screen.Recording.2024-07-15.at.17.51.28.mov