Quality: Remove "reusable block name hint" code#63514
Merged
Conversation
t-hamano
added
[Feature] Synced Patterns
|
Size Change: -742 B (-0.04%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Jul 14, 2024
Comment on lines
-733
to
-736
| ### ReusableBlocksRenameHint | ||
|
|
||
| Undocumented declaration. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Oh, I just realized that this component is both private and public at the same time 😅
According to WPdirectory's results, there are two plugins other than the Gutenberg plugin that use this component.
Should we keep this component?
Member
There was a problem hiding this comment.
I wonder if those two plugins are bundling the block-editor package. I can't find the ReusableBlocksRenameHint instance in their codebase.
The same is probably true for the "Kubio AI Page Builder" plugin.
Contributor
Author
There was a problem hiding this comment.
I downloaded the two plugins. Neither plugin has pre-build code, but looking at the build files, it doesn't look like they use this component.
Therefore, I think it's safe to delete it.
Member
There was a problem hiding this comment.
Yeah, it should be okay. Let's wait until tomorrow if others have different opinions regarding the public component.
Member
|
Let's merge this. |
|
Flaky tests detected in 5b7faae. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9990073768
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #52664
What?
This PR removes the block name hint, and associated code, from the Create Pattern modal.
Why?
This hint was added in WordPress 6.3 to let users know that the name changed from "Reusable Block" to "Synced Pattern". As this comment indicates, this hint was scheduled to be removed in 6.4, so I don't think it's necessary anymore.
How?
I've removed the relevant components, hooks and CSS. they're private APIs so it should be fine to remove them directly.
Testing Instructions
http://localhost:8888/wp-admin/post-new.php?post_type=wp_block.