Details block: add transform from any block type #63422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +113 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Jul 11, 2024
|
One tweak would be to not have the transform on the details block itself.
|
ellatrix
force-pushed
the
try/details-transform
branch
from
a0b6fca to
1d7e1ba
Compare
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: fjorgemota <fjorgemota@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ran into the problem of not being able to select blocks and moving them into a details blocks. This PR adds a transform for that. Fixes #55602. See also #51247.
Why?
It's not currently possible to move content into a details block.
How?
Testing Instructions
Create some block, then select them and click the block icon to transform them into the details block.
Also singular blocks can be transformed.
Testing Instructions for Keyboard
Screenshots or screencast