Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Removed shuffle button when only 1 pattern is present #63093

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix: Removed shuffle button when only 1 pattern is present #63093

merged 1 commit into from
Jul 17, 2024

Conversation

Sourav61
Copy link
Contributor

@Sourav61 Sourav61 commented Jul 3, 2024

Fixes #63069

What?

Removes the shuffle button when only 1 pattern is present in the same category

Why?

Currently, if we have a single pattern having a single category then we are seeing the shuffle button in the toolbar which shouldn't be there as there is no other pattern to go to.

How?

I have updated the condition to display the shuffle button only if we have 2 or more unsynced patterns of the same category.

Testing Instructions

  1. Create a simple unsynced pattern with a unique category, make sure the contents of the group are wrapped in a single group block.
  2. Using the + menu in the top left, insert the pattern.
  3. The shuffle button would not appear.

@Sourav61
Fix: Removed shuffle button when only 1 pattern is present
ca01d4e 
Removed shuffle button when only 1 pattern is present of the same category
@Sourav61 Sourav61 requested a review from ellatrix as a code owner July 3, 2024 13:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @laurelfulford.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: laurelfulford.

Co-authored-by: Sourav61 <sourav08@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Sourav61! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 3, 2024
talldan
talldan approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Sourav61, this fix is testing well 👍

@talldan talldan merged commit 64caa32 into WordPress:trunk Jul 17, 2024
66 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 17, 2024
@talldan talldan added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Jul 17, 2024
@noisysocks
Copy link
Member

noisysocks commented Jul 18, 2024 •
edited
Loading

Tested this against wp/6.6, looks good 👍

@ellatrix ellatrix added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 18, 2024
ellatrix pushed a commit that referenced this pull request Jul 18, 2024
@Sourav61 @talldan @ellatrix
Fix: Removed shuffle button when only 1 pattern is present (#63093)
07d5d60 
Removed shuffle button when only 1 pattern is present of the same category

----

Unlinked contributors: laurelfulford.

Co-authored-by: Sourav61 <sourav08@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
@ellatrix
Copy link
Member

Manually backported in 07d5d60

@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release labels Jul 18, 2024
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Jul 18, 2024
@hellofromtonya
Editor: Update packages for 6.6.1.
53f1c43 
Bugfixes included:

* [WordPress/gutenberg#63637 Elements: Avoid specificity bump for top-level element-only selectors].
* [WordPress/gutenberg#63406 Navigation block: Allow themes to override block library text-decoration rule].
* [WordPress/gutenberg#63436 Fix invalid css for nested fullwidth layouts with zero padding applied].
* [WordPress/gutenberg#63397 Prevent empty void at the bottom of editor when block directory results are present].
* [WordPress/gutenberg#63291 Pattern overrides: Ensure "Reset" button always shows as last item and with border].
* [WordPress/gutenberg#63562 Global Styles: Disable "Reset styles" button when there are no changes].
* [WordPress/gutenberg#63093 Fix: Removed shuffle button when only 1 pattern is present].
* [WordPress/gutenberg#62675 fix: wp icon focus issue].
* [WordPress/gutenberg#63565 useBlockElement: return null until ref callback has time to clean up the old element].

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.

git-svn-id: https://develop.svn.wordpress.org/trunk@58757 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 18, 2024
@hellofromtonya
Editor: Update packages for 6.6.1.
5f637ea 
Bugfixes included:

* [WordPress/gutenberg#63637 Elements: Avoid specificity bump for top-level element-only selectors].
* [WordPress/gutenberg#63406 Navigation block: Allow themes to override block library text-decoration rule].
* [WordPress/gutenberg#63436 Fix invalid css for nested fullwidth layouts with zero padding applied].
* [WordPress/gutenberg#63397 Prevent empty void at the bottom of editor when block directory results are present].
* [WordPress/gutenberg#63291 Pattern overrides: Ensure "Reset" button always shows as last item and with border].
* [WordPress/gutenberg#63562 Global Styles: Disable "Reset styles" button when there are no changes].
* [WordPress/gutenberg#63093 Fix: Removed shuffle button when only 1 pattern is present].
* [WordPress/gutenberg#62675 fix: wp icon focus issue].
* [WordPress/gutenberg#63565 useBlockElement: return null until ref callback has time to clean up the old element].

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.
Built from https://develop.svn.wordpress.org/trunk@58757


git-svn-id: http://core.svn.wordpress.org/trunk@58159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to gilzow/wordpress-performance that referenced this pull request Jul 18, 2024
@hellofromtonya
Editor: Update packages for 6.6.1.
6fba513 
Bugfixes included:

* [WordPress/gutenberg#63637 Elements: Avoid specificity bump for top-level element-only selectors].
* [WordPress/gutenberg#63406 Navigation block: Allow themes to override block library text-decoration rule].
* [WordPress/gutenberg#63436 Fix invalid css for nested fullwidth layouts with zero padding applied].
* [WordPress/gutenberg#63397 Prevent empty void at the bottom of editor when block directory results are present].
* [WordPress/gutenberg#63291 Pattern overrides: Ensure "Reset" button always shows as last item and with border].
* [WordPress/gutenberg#63562 Global Styles: Disable "Reset styles" button when there are no changes].
* [WordPress/gutenberg#63093 Fix: Removed shuffle button when only 1 pattern is present].
* [WordPress/gutenberg#62675 fix: wp icon focus issue].
* [WordPress/gutenberg#63565 useBlockElement: return null until ref callback has time to clean up the old element].

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.
Built from https://develop.svn.wordpress.org/trunk@58757


git-svn-id: https://core.svn.wordpress.org/trunk@58159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Jul 18, 2024
@hellofromtonya
Editor: Update packages for 6.6.1.
7189988 
Bugfixes included:

* [WordPress/gutenberg#63637 Elements: Avoid specificity bump for top-level element-only selectors].
* [WordPress/gutenberg#63406 Navigation block: Allow themes to override block library text-decoration rule].
* [WordPress/gutenberg#63436 Fix invalid css for nested fullwidth layouts with zero padding applied].
* [WordPress/gutenberg#63397 Prevent empty void at the bottom of editor when block directory results are present].
* [WordPress/gutenberg#63291 Pattern overrides: Ensure "Reset" button always shows as last item and with border].
* [WordPress/gutenberg#63562 Global Styles: Disable "Reset styles" button when there are no changes].
* [WordPress/gutenberg#63093 Fix: Removed shuffle button when only 1 pattern is present].
* [WordPress/gutenberg#62675 fix: wp icon focus issue].
* [WordPress/gutenberg#63565 useBlockElement: return null until ref callback has time to clean up the old element].

Reviewed by spacedmonkey.
Merges [58757] to the 6.6 branch.

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.

git-svn-id: https://develop.svn.wordpress.org/branches/6.6@58760 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 18, 2024
@hellofromtonya
Editor: Update packages for 6.6.1.
e6d8ac1 
Bugfixes included:

* [WordPress/gutenberg#63637 Elements: Avoid specificity bump for top-level element-only selectors].
* [WordPress/gutenberg#63406 Navigation block: Allow themes to override block library text-decoration rule].
* [WordPress/gutenberg#63436 Fix invalid css for nested fullwidth layouts with zero padding applied].
* [WordPress/gutenberg#63397 Prevent empty void at the bottom of editor when block directory results are present].
* [WordPress/gutenberg#63291 Pattern overrides: Ensure "Reset" button always shows as last item and with border].
* [WordPress/gutenberg#63562 Global Styles: Disable "Reset styles" button when there are no changes].
* [WordPress/gutenberg#63093 Fix: Removed shuffle button when only 1 pattern is present].
* [WordPress/gutenberg#62675 fix: wp icon focus issue].
* [WordPress/gutenberg#63565 useBlockElement: return null until ref callback has time to clean up the old element].

Reviewed by spacedmonkey.
Merges [58757] to the 6.6 branch.

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.
Built from https://develop.svn.wordpress.org/branches/6.6@58760


git-svn-id: http://core.svn.wordpress.org/branches/6.6@58162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@Sourav61 @talldan @carstingaxion
Fix: Removed shuffle button when only 1 pattern is present (WordPress…
07b0753 
…#63093)

Removed shuffle button when only 1 pattern is present of the same category

----

Unlinked contributors: laurelfulford.

Co-authored-by: Sourav61 <sourav08@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
@t-hamano t-hamano mentioned this pull request Jul 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 18.9
Development

Successfully merging this pull request may close these issues.

Block Pattern: Shuffle button appears in toolbar even when no patterns to shuffle to in WP 6.6 RC 2
5 participants
@Sourav61 @noisysocks @ellatrix @talldan @akasunil