Performance: reduce block support hook calls further with isMatch #62684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +709 B (+0.04%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
added
the
Backport to WP 6.8 Beta/RC
I'd appreciate guidance on how to verify these tests, both to check the changes here and to catch performance issues elsewhere as well |
|
@vcanales You can check the test re-runs |
jorgefilipecosta
approved these changes
Jun 21, 2024
ellatrix
removed
the
Backport to WP 6.8 Beta/RC
|
@ellatrix, let's rebase this, and it probably should be good to be merged. |
|
Yes, would be good. I just didn't see a performance improvement so I paused it 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we only filter block support hook calls when it doesn't match the top level attribute name. The problem is that these attributes have evolved to nested
styleproperties, which causes these all of these hooks to match as soon as a block has a style attribute, even if the styles are not relevant.Why?
Performance.
Site editor load patterns: -12.44%, -6.2%, 2.9%, -4.67%
Navigate: -2.47%, -3.39%, -10.28%, -10.87%
How?
There's already an
isMatchfunction so block support hooks can fine-tune which blocks should match.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast