Raw handling: fix too aggressive indented list removal #62622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
commented
Jun 17, 2024
| const input = '<ul><li>\n<ul><li>test</li></ul>\n</li></ul>'; | ||
| const output = '<ul><li>test</li></ul>'; | ||
| expect( deepFilterHTML( input, [ listReducer ] ) ).toEqual( output ); | ||
| } ); |
There was a problem hiding this comment.
The important tests are actually the integration tests, and curiously this doesn't make any integration tests fail, so it seems fine to leave content as it is.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 589d266. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9547746000
|
|
Made a test, seem to work well. |
saulyz
approved these changes
Jun 18, 2024
jorgefilipecosta
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
The content loss was fixed.
I pasted the following code on the code editor:
<h3>Some heading</h3>
<ul>
<li style="list-style-type: none;">
<ul><!-- /wp:list-item --> <!-- wp:list-item --></ul>
</li>
<li>Content we need to preserve</li>
</ul>
I used the convert to blocks option and verified "Content we need to preserve" was preserved.
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: saulyz <sauliusv@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 057b484 |
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: saulyz <sauliusv@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #62545, where @saulyz discovered that list item content is stripped when there's an empty list in an empty list item.
Why?
Content loss.
Currently indented lists are too aggressively outdented or removed entirely.
How?
Removal of unneeded logic.
Testing Instructions
Includes unit and integration tests.
Testing Instructions for Keyboard
Screenshots or screencast