Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Improve the aria-disabled focus style #62480

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Button: Improve the aria-disabled focus style #62480

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4ecbcb
Improve Button aria-disabled focus style.
afercia Jun 11, 2024
b05c682
Add changelog entry.
afercia Jun 11, 2024
52c2b45
Adjust changelog entry after rebase.
afercia Jun 19, 2024
41a4cec
Adjust changelog entry after rebase.
afercia Jun 28, 2024
14ccb32
Introduce new gray-500 for disabled controls.
afercia Jul 23, 2024
de838e0
Use gray-500 for all disabled button variants.
afercia Jul 23, 2024
84417c3
Fix is-pressed disabled styles regression
ciampo Jul 31, 2024
f77f13c
Revert the introduction of the gray-500 variable
ciampo Jul 31, 2024
496e303
Merge branch 'trunk' into fix/disabled-button-focus-style
mirka Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use gray-500 for all disabled button variants.
  • Loading branch information
@afercia @ciampo
afercia authored and ciampo committed Jul 31, 2024
commit de838e0032dc6d7bcaa4871d48aff51697769401
6 changes: 3 additions & 3 deletions packages/components/src/button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
&:disabled,
&[aria-disabled="true"],
&[aria-disabled="true"]:hover {
color: $gray-600;
color: $gray-500;
background: transparent;
transform: none;
}
Expand Down Expand Up @@ -212,7 +212,7 @@

&:disabled,
&[aria-disabled="true"] {
color: lighten($alert-red, 40%);
color: $gray-500;
}
}
}
Expand Down Expand Up @@ -244,7 +244,7 @@

&:disabled,
&[aria-disabled="true"] {
color: $gray-600;
color: $gray-500;
}
}

Expand Down