Fix: Pattern details page backpath #61174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
fix/pattern-details-page-routing
branch
from
f19ff06
to
abbaac7
Compare
jsnajdr
approved these changes
Apr 30, 2024
|
@jsnajdr Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #61172
Related to #60466
What?
This PR ensures that the previously selected category is selected when you return from the Pattern details/Template part details page.
Why?
On the pattern page, the
categoryTypeparameter indicates which template part or pattern is selected, and thecategoryIdparameter indicates which category is selected.Previously, these parameters were carried over when returning from the details page, but after #60466 was merged, it appears that the only explicitly specified parameter (
path) is carried over.How?
I explicitly included
categoryIdandcategoryTypein thebackpath. I would appreciate any advice on whether this is the correct approach.Testing Instructions
Patterns
Template Part
Screenshots or screencast
c08905ff2eb549a55923ce051e6393fa.mp4