Separator block: Reduce default border styles to avoid conflicts with global styles #60740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Regression
|
Size Change: +27 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM
The theme's styles take precedence
Before
After
Nothing to do with this PR, but I also noticed that Gutenberg/WordPress prints out an empty CSS rule for blocks, even where they have no rules.
In the global-styles-inline-css stylesheet, I see .wp-block-separator{}. 🤷🏻
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dashkevych. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60634, similar to #60649
Reduce the specificity of the Separator block's default border rules.
Why?
With global styles rules specificity being reduced as of #60106, the default border styles for the Separator block unintentionally override border rules set for the Separate block in
theme.json. This is a slightly tricky issue as the Separator block has not formally opted in to the Borer block support. However custom border rules are in use in TT4 so it's a good bug to address.Because some themes might still depend on the higher specificity of the
theme.scssrules, I've left them untouched. A good example would be a Classic theme that uses overly specific reset rules to set borders to0but that then opts in towp-block-stylesto receive the opinionated block styles. If we believe those rules should be lowered, too (thetheme.scssones for this block), I'd suggest looking at doing that in a separate PR potentially.How?
Wrap the Separator block's border styles in a
:where()rule for consistency with global styles rules.Testing Instructions
Screenshots or screencast
Before
The Separator block's
2pxrule overrides the1pxfrom TT4:After
TT4's
1pxrule overrides the Separator block's default styles:Here's where TT4 sets its width:
https://github.com/WordPress/wordpress-develop/blob/f6747a384f56893aac4870979c71f02f72d2e624/src/wp-content/themes/twentytwentyfour/theme.json#L743