-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert shortcode package to TypeScript #60526
base: trunk
Are you sure you want to change the base?
Convert shortcode package to TypeScript #60526
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Happy to close mine :) |
Nice! It’s exactly what needs to happen next. We definitely need to refresh this PR. @mikeybinns, will you have time to rebase this branch with |
Ok, good. We definitely want to reuse all the new tests introduced in addition to other changes proposed ❤️ |
Okay, in that case, I will rebase it when I have time :) |
What?
Converting the shortcodes package to TypeScript.
Why?
It's an enhancement, while not necessary it is helpful to reduce bugs in both the code of the package and end users code if they consume types.
How?
attrs
method from shortcode class as it was inaccessible due to a property of the same name.attrs
function is still exported separately as before.Testing Instructions
Covered by automatic tests.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A