Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background image: move controls into a popover #60151

Merged
merged 11 commits into from
Jul 3, 2024
Merged

Background image: move controls into a popover #60151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ca6be90
Testing other component layout and dummy toolspanel items
ramonjd Mar 28, 2024
055878a
Rejigging components, catering for no-background-image-controls
ramonjd Jun 19, 2024
c1f4648
With tabs
ramonjd Jun 20, 2024
6640acb
Revert tabs and move the image upload to the floating panel
ramonjd Jun 25, 2024
ca9f7b8
Temp hack to push popover into the background
ramonjd Jun 25, 2024
37dd1e2
Fix hack to push popover into the background
ramonjd Jun 25, 2024
808fb80
Tweak size of media flow dropdown
ramonjd Jun 27, 2024
bf0aab0
Remove default controls override as there's only 'background image' now.
ramonjd Jun 28, 2024
6836456
Rolling back expanding popover in mobile.
ramonjd Jul 2, 2024
d0a56df
Remove commented-out code
ramonjd Jul 2, 2024
34d20ce
Revert input sizes
ramonjd Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix hack to push popover into the background
  • Loading branch information
@ramonjd
ramonjd committed Jul 3, 2024
commit 37dd1e2e06aa0a5bdfc0b486bff7deaed0218171
4 changes: 3 additions & 1 deletion packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ $z-layers: (
// Needs to be below media library that has a z-index of 160000.
"{core/video track editor popover}": 160000 - 10,

// Needs to be below media library that has a z-index of 160000.
// Needs to be below media library (.media-model) that has a z-index of 160000.
".block-editor-format-toolbar__image-popover": 160000 - 10,
// Below the media library backdrop (.media-modal-backdrop), which has a z-index of 159900.
".block-editor-global-styles-background-panel__popover": 159900 - 10,

// Small screen inner blocks overlay must be displayed above drop zone,
// settings menu, and movers.
Expand Down
1 change: 1 addition & 0 deletions packages/block-editor/src/components/global-styles/background-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const BACKGROUND_POPOVER_PROPS = {
placement: 'left-start',
offset: 36,
shift: true,
className: 'block-editor-global-styles-background-panel__popover',
};
const noop = () => {};

Expand Down
7 changes: 3 additions & 4 deletions packages/block-editor/src/components/global-styles/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@
position: absolute;
}

// Hack to push into background when the media modal is open.
// @TODO how to target the background panel specifically?
.modal-open .components-dropdown__content {
z-index: 100000;
// Push control panel into the background when the media modal is open.
.modal-open .block-editor-global-styles-background-panel__popover {
z-index: z-index(".block-editor-global-styles-background-panel__popover");
}