Follow up design tweaks for global styles presets #60031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +409 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
richtabor
added
[Type] Enhancement
jasmussen
approved these changes
Mar 20, 2024
packages/edit-site/src/components/global-styles/variations/style.scss
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @sahiladit. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
reviewed
Mar 20, 2024
|
This readds the "Presets" heading, I assume that is intentional? |
scruffian
reviewed
Mar 20, 2024
scruffian
reviewed
Mar 20, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
scruffian
reviewed
Mar 20, 2024
You need to fork the repo, and then create a new branch on your fork. There's a lot more detail here: https://github.com/WordPress/gutenberg/blob/c1032abaf71e86f0effe13a181ba189c083f98ef/docs/contributors/code/README.md |
scruffian
reviewed
Mar 20, 2024
|
|
||
| export default function TypographyVariations() { | ||
| export default function TypographyVariations( { title, gap = 2 } ) { |
There was a problem hiding this comment.
I'm not super keen on adding gap as a prop. Style variations have a gap of 3 in both contexts, so I'd rather keep that for consistency and simplicity.
There was a problem hiding this comment.
Style variations have a gap of 3 in both contexts, so I'd rather keep that for consistency and simplicity.
They shouldn't though. In the smaller context of the Inspector, the gap should be 2, but in the wider context of the dark material, they need a gap of 3.
There was a problem hiding this comment.
If you have another idea to achieve the same result, I'm open to it.
There was a problem hiding this comment.
I updated the styles tiles to use a gap of 3 in site view.
Yes. After testing without it I think it's fine to include. Perhaps we can come up with a better solution and revisit, but for now this puts us in a good spot. I had this in mind, which works ok for colors—but not so much for typography.
|
|
Flaky tests detected in 068cdf8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8378044486
|
scruffian
approved these changes
Mar 21, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Update ColorToolsPanel to "Elements" H3 * Improve copy and spacing on "colors" screen * Tweak HighlightedColors size and spacing * Tweak palette count visual and empty state copy * Tweak styles * Add "Presets" subtitle, adjust grid * Tweaks * Add back 'custom' * Adjust spacing of font families * Adjust subtitles * Use $border-width * Linting * Fix consistent margin top * remove unused styles * Remove duplicate VStack * Add reduce-motion and comments for box shadow transitions * also set the gap on the style variation component * use a generic class for shared styles --------- Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #56622, in support of #56604.
Fixes #59948
Testing Instructions
Screenshots or screencast