Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Prevent react-native-video crash that happens when an src changes quickly after first being set #59841

Merged
merged 4 commits into from
Mar 13, 2024
Merged

[RNMobile] Prevent react-native-video crash that happens when an src changes quickly after first being set #59841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cf9fd4
fix: Avoid crash by preventing quick src changes
Mar 13, 2024
ea55c9a
refactor: New line at end of const for readability
Mar 13, 2024
8f75db3
Merge branch 'trunk' into rnmobile/fix-react-native-video-crash
Mar 13, 2024
fc13976
docs: Add CHANGELOG entry
Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/block-library/src/video/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,10 @@ class VideoEdit extends Component {
} ) => {
const showVideo =
isURL( src ) &&
getProtocol( attributes.src ) !== 'file:' &&
! isUploadInProgress &&
! isUploadFailed;

const icon = this.getIcon(
isUploadFailed
? ICON_TYPE.RETRY
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ For each user feature we should also add a importance categorization label to i
- [*] Gallery block items with in-progress, paused, or failed media uploads correctly display an highlight outline when selected [#59423]
- [**] [internal] Upgrade React Native to version 0.73.3 [#58475]
- [**] Add error boundary components and exception logging [#59221]
- [**] Fix crash occurring when the URL associated with a Video block is changed too quickly [#59841]

## 1.114.1
- [**] Fix a crash produced when the content of a synced pattern is updated [#59632]
Expand Down
Loading