Try obviating Popover pointer event trap #59449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -363 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
stokesman
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
This works well in my testing, both in Storybook and in the editor itself.
Great cleanup and definitely a more elegant solution to the problem. Nice work @stokesman 🚀
Could you just add a CHANGELOG entry? I think it will be useful.
stokesman
force-pushed
the
try/obviate-popover-pointer-event-trap
branch
2 times, most recently
from
23b1b98 to
a7b49e6
Compare
|
Thanks for testing and reviewing Marin 🙇. I’ve added a changelog. |
tyxla
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Thanks for working on a cleaner and simpler solution @stokesman 🙌 🚀
stokesman
force-pushed
the
try/obviate-popover-pointer-event-trap
branch
from
a7b49e6 to
21acd77
Compare
mirka
reviewed
Mar 22, 2024
| // iframes. If a newer version of react-colorful begins to employ | ||
| // pointer capture this will be redundant and should be removed. | ||
| onPointerDown={ ( { currentTarget, pointerId } ) => { | ||
| currentTarget.setPointerCapture( pointerId ); |
| ) } | ||
| <motion.div | ||
| className={ classnames( 'components-popover', className, { |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Partially revert "ColorPicker: improve UX of dragging the handle when in popover on top of the editor (WordPress#55149)" This reverts commit 9da6f48. * Use pointer capture to improve drag gesture UX * Use the context system again * Update snapshot * Remove unnecessary context provider * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Largely reverts the changes from #55149 and instead employs pointer capture in the color picker component.
Why?
Simplification.
How?
Using pointer capture during drag gestures prevents object like iframes from receiving pointer events and interfering with the drag gesture.
Testing Instructions
Testing Instructions for Keyboard
The changes here should only be relevant to the drag gestures which cannot be tested by keyboard.
Screenshots or screencast
color.picker.pointer.capture.mp4
More info
There is potential that a future version of the react-colorful library may use pointer capture itself and we'd be able to remove that from the ColorPicker component. A PR for such has been opened in the past and the author declined to merge at the time because they prioritize supporting older browsers. I'm pretty sure the WordPress policy on browser support is in the clear for use of PointerEvents/capture.