Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font face resolver: print font faces from font families defined in all theme.json origins #59321

Closed

Conversation

matiasbenedetto
Copy link
Contributor

What?

Font face resolver: print font faces from font families defined in all theme.json origins

Why?

Porting this fix from core PR: WordPress/wordpress-develop#6161

How?

see WordPress/wordpress-develop#6161

Testing Instructions

see WordPress/wordpress-develop#6161

@matiasbenedetto matiasbenedetto added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Feb 23, 2024
@matiasbenedetto matiasbenedetto marked this pull request as draft February 23, 2024 16:36
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto
Copy link
Contributor Author

matiasbenedetto commented Feb 23, 2024

Draft until WordPress/wordpress-develop#6161 is merged

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/fonts/font-face/class-wp-font-face-resolver.php
❔ lib/compat/wordpress-6.4/fonts/fonts.php

@matiasbenedetto
Copy link
Contributor Author

Closing this PR as duplicated of #59376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant