Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More/backports for beta 2 #59208

Merged
merged 22 commits into from
Feb 20, 2024
Merged

More/backports for beta 2 #59208

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3c9d2cd
Font Library: Replace infinite scroll by pagination (#58794)
pbking Feb 13, 2024
d50c836
Revert "Block Hooks: Set ignoredHookedBlocks metada attr upon inserti…
ockham Feb 13, 2024
16f7948
DataViews: Fix patterns, templates and template parts pagination `z-i…
ntsekouras Feb 13, 2024
50244c6
Block Bindings: Fix disable bindings editing when source is undefined…
SantosGuillamot Feb 13, 2024
942cc3e
Patterns: Fix pattern categories on import (#58926)
ntsekouras Feb 13, 2024
0ef370b
Shadows: Don't assume that core provides defaults (#58973)
scruffian Feb 13, 2024
0f3e9fb
Inserter: Don't select the closest block with editing mode set as dis…
Mamaduka Feb 14, 2024
79dffd9
Make the custom CSS validation error message accessible. (#56690)
afercia Feb 14, 2024
a01f6a7
Inserter: Fix title condition for media tab previews (#58993)
Mamaduka Feb 14, 2024
1e70298
DataViews: Add loading/no results message in grid view (#59002)
ntsekouras Feb 14, 2024
4b25a88
Block editor: pass patterns selector as setting (#58661)
ellatrix Feb 14, 2024
00f7e12
Font Libary: Add missing translation functions (#58104)
t-hamano Feb 15, 2024
9b48e86
Background image support: Fix issue with background position if keybo…
andrewserong Feb 15, 2024
e53ba3b
Editor: Do not open list view by default on mobile (#59016)
youknowriad Feb 15, 2024
18c62df
Refactor to use string instead of an object (#59030)
cbravobernal Feb 15, 2024
81115e7
Fix DFM ui toggling bugs (#59061)
draganescu Feb 15, 2024
2958043
Rich text: fix link paste for internal paste (#59063)
ellatrix Feb 15, 2024
974f545
Image: Mark connected controls as 'readyonly' (#59059)
Mamaduka Feb 15, 2024
ea8ea99
Global Styles: fix console error in block preview (#59112)
t-hamano Feb 16, 2024
1236a04
Site Editor: Fix navigation on mobile web (#59014)
youknowriad Feb 15, 2024
2181591
Revert footer in pages list with DataViews (#59151)
ntsekouras Feb 19, 2024
dfe3d0d
Fix build
youknowriad Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Shadows: Don't assume that core provides defaults (#58973) 
Co-authored-by: vcanales <vcanales@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>
  • Loading branch information
@scruffian @vcanales @youknowriad
3 people authored and youknowriad committed Feb 20, 2024
commit 0ef370b794bb5f8da5c0ad411e10b5336e9f03e5
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/global-styles/shadow-panel-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ import { shadow as shadowIcon, Icon, check } from '@wordpress/icons';
import classNames from 'classnames';

export function ShadowPopoverContainer( { shadow, onShadowChange, settings } ) {
const defaultShadows = settings?.shadow?.presets?.default;
const themeShadows = settings?.shadow?.presets?.theme;
const defaultShadows = settings?.shadow?.presets?.default || [];
const themeShadows = settings?.shadow?.presets?.theme || [];
const defaultPresetsEnabled = settings?.shadow?.defaultPresets;

const shadows = [
...( defaultPresetsEnabled ? defaultShadows : [] ),
...( themeShadows || [] ),
...themeShadows,
];

return (
Expand Down