CustomSelectControl: Hard deprecate constrained width #58974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -281 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9f2d011. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7902241151
|
tyxla
approved these changes
Feb 14, 2024
| @@ -114,14 +112,6 @@ Can be used to externally control the value of the control, like in the `MyContr | |||
| - Type: `Object` | |||
| - Required: No | |||
|
|
|||
| #### __nextUnconstrainedWidth | |||
There was a problem hiding this comment.
Should we also remove the corresponding prop from the legacy types:
There was a problem hiding this comment.
Based on our discussion in #55401, we're going to keep it in the types indefinitely so consumer code can continue to compile, and to prevent future prop name collisions.
mirka
added
has dev note
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Promotes
__nextUnconstrainedWidthon CustomSelectControl to the default behavior.Why?
The deprecation grace period has elapsed.
Testing Instructions
Unfortunately, this compatibility mode had broken at some point, so you won't even be able to see this width switching behavior on Storybook trunk 😱
If you build Storybook on this PR branch, you should be able to see that:
__nextUnconstrainedWidthprop is removed from the docs.✍️ Dev Note
CustomSelectControlused to have a hard-coded width, which was inconsistent with our other form components. In WordPress 6.1, we deprecated this unconstrained width, and introduced the transitional__nextUnconstrainedWidthprop so consumers could opt into these new styles before they become the default.In WordPress 6.5, these unconstrained width styles have become the default. Any use of the
__nextUnconstrainedWidthprop can be safely removed.