Rich text: Honour embed-URL-on-paste setting for internal values too #58786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
I think I tracked down the cause: #57487 (comment) While this fixes embeds, does it fix link on paste too? Would be good to have an e2e test. We can set the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
In the issue, Riad claims a different cause: #57487 (comment)
Not sure I understand: link on paste was the one thing I sought to fix. |
youknowriad
added
Backported to WP Core
ellatrix
reviewed
Feb 12, 2024
| // If the data comes from a rich text instance, we can directly use it | ||
| // without filtering the data. The filters are only meant for externally | ||
| // pasted content and remove inline styles. | ||
| if ( isInternal ) { |
There was a problem hiding this comment.
This works, but I would much rather make the logic below that handles __unstablePasteRule transforms reusable and run it here as well, instead of making an exception for URLs and letting that from through the paste handler for nothing. What do you think?
There was a problem hiding this comment.
@ellatrix: Fine by me! This was just a quick stab, but I'll happily defer to a more comprehensive solution of your making.
|
Closing in favour of #59063 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57487
Here's a quick stab from someone with limited knowledge of Rich Text. Can this break other things? :)