Revert "Add defaultFontSizes option to theme.json (#56661)"#58456
Merged
cbravobernal merged 1 commit intotrunkfrom Jan 30, 2024
Merged
Revert "Add defaultFontSizes option to theme.json (#56661)"#58456cbravobernal merged 1 commit intotrunkfrom
cbravobernal merged 1 commit intotrunkfrom
Conversation
This reverts commit 940f0fe.
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
ajitbohra,
ajlende,
ellatrix,
fabiankaegy,
juanmaguitar,
ndiego,
ryanwelcher and
spacedmonkey
as code owners
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/class-wp-theme-json-gutenberg.php ❔ lib/theme.json |
|
Size Change: -185 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
SantosGuillamot
approved these changes
Jan 30, 2024
Contributor
SantosGuillamot
left a comment
SantosGuillamot
left a comment
There was a problem hiding this comment.
I've tested it and everything seems to work. This is what I did:
- In a site, install a theme with fontSizes defined in the
theme.jsonusing theslugand name "small" and a size you can identify:
{
"fluid": false,
"name": "Small",
"size": "20px",
"slug": "small"
},
You can do the same with medium and large.
- In a page or in the Site editor, go to the styles of a paragraph and check that the value defined by the theme is applied. Before this pull request it applies Gutenberg value.
- Go to the frontend and check that works as well.
- Remove the "small" font size you added.
- Check now that the "small" font size is still there but with the Gutenberg default value.
Contributor
Author
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 2ef4028 |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This reverts commit 940f0fe.
Fixes #57889 by reverting #56661
Testing Instructions
Step-by-step reproduction instructions