Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LINE social icon to social icons block (Fixes #57830) #58043

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

niikhilpatel
Copy link

@niikhilpatel niikhilpatel commented Jan 20, 2024

What?
The PR #57830 is adding a new LINE icon to the social icons block, addressing the need to include LINE messenger, which is popular and essential in some Asian countries. The LINE icon is introduced to complement the existing social icons.

Why?
This PR is necessary to enhance the social media integration of the application. The addition of the LINE icon caters to the user base in Asian countries where LINE is widely used. It aligns with the goal of providing a comprehensive set of social icons for users to choose from (Issue: "Add LINE to social icons block").

How?
The implementation involves introducing a new SVG component specifically for the LINE icon. The code structure is modeled after existing social icons, ensuring consistency. The SVG code for the LINE icon is generated based on a provided sample (uploaded SVG) to accurately represent the LINE logo.

Testing Instructions
Open a post or page.
Insert a social icons block.
Observe the presence of the new LINE icon in the social icons list.
Click on the LINE icon to ensure it functions as expected.
Test the responsiveness of the LINE icon in various screen sizes.
Save the changes and preview the post/page to verify the LINE icon persists.

Tags:

  • [Type] Enhancement
  • [Status] Ready for Review

Copy link

github-actions bot commented Jan 20, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: First-time Contributor, [Block] Social.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 20, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @niikhilpatel! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants