Font Library Modal: Reset the selected font when installing a new font #57817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Enhancement
|
Size Change: +26 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
vcanales
approved these changes
Jan 12, 2024
packages/edit-site/src/components/global-styles/font-library-modal/context.js
Outdated
Show resolved
Hide resolved
jffng
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
This works as advertised.
It does change the behavior of navigating between the tabs. Currently, if you navigate to a specific font + variant list in the Library tab, then you navigate to the Upload tab and install a font, then navigate back to Library, you're at the specific font where you left off.
This changes the behavior so that the Library tab is always reset after trying to install a font, even if it fails.
I think I'm okay with that, so ✅
|
Thanks @vcanales and @jffng for the reviews!
I'm not sure about this behaviour when the installation fails - I've changed it back so |
|
I think I've found a better way to handle this 👀 I've added a call to This keeps the behaviour when switching tabs the same as before, but the variant list is updated immediately. Sorry for changing my mind - this is ready for another review! 🙇 |
jffng
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a small PR to reset the selected font (
libraryFontSelected) when installing a new font.Why?
Fixes #54945.
How?
Adds a call to
setLibraryFontSelectedininstallFontwhich sets thelibraryFontSelectedtonull.This means that when navigating back to the installed fonts list in the Font Library modal, the initial list of fonts is shown rather than the previously selected font. This also means that the list is up to date, including the latest installed font. Previously, you had to navigate back to the list of installed fonts manually in order to reset the selected font.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-01-12.at.17.51.29.mov