-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Fix missing custom gradient indicator in the color palette #57605
Conversation
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
Flaky tests detected in f634ef2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7424245693
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
I added some suggestions but none shouldn't block the merge of the PR.
packages/components/src/mobile/color-settings/palette.screen.native.js
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/react-native-editor/CHANGELOG.md
Fixes #42017
What?
This PR fixes a regression most likely introduced in #38417 where we added support for multiple color palettes where the custom color indicator is not shown for custom gradient colors.
Why?
To fix a UI regression and possibly avoid confusion for users when they customize their gradient colors.
How?
The custom indicator wasn't being shown due to not having all of the gradient colors available for the current color segment being rendered.
We also limit the custom indicator to only be visible in the first available color palette row, since users can have up to three:
Default
,Theme
, andCustom
colors.Testing Instructions
Note
These changes need to be tested using the main host apps and a theme that has custom gradients e.g: Twenty Twenty-Four
Testing Instructions for Keyboard
N/A
Screenshots or screencast
GradientIndicatorFix.mov