Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position and size of the Options menu, #57515

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix the position and size of the Options menu, #57515

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f3e9e
Fix the position and size of the Options menu,
afercia Jan 3, 2024
73b8cb3
Merge branch 'trunk' into fix/options-menu-position-and-size
carolinan Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the position and size of the Options menu,
  • Loading branch information
@afercia
afercia committed Jan 3, 2024
commit 43f3e9ed2bdf79149c441700053b0bad5562ed81
20 changes: 1 addition & 19 deletions packages/edit-post/src/components/header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,6 @@
@include break-zoomed-in {
flex-wrap: nowrap;
}

// Some browsers, most notably IE11, honor an older version of the flexbox spec
// which takes absolutely positioned items into account when calculating `space-between`.
// https://www.w3.org/TR/2012/WD-css3-flexbox-20120612/#abspos-flex-items
//
// This difference is causing our header layout to break when focused in IE11.
// Our focused region styles use an absolutely positioned :after pseudo element to draw an outline,
// and IE11 is adding space between it and our last real child, shifting righthand UI elements
// to the left. For a workaround, we change the flex order to move the undesired spacing to the middle
// where it is no longer noticeable.
> .edit-post-header__settings {
order: 1;

// Restore default order for all other browsers
@supports (position: sticky) {
order: initial;
}
}
}

.edit-post-header__toolbar {
Expand Down Expand Up @@ -121,7 +103,7 @@
padding-right: $grid-unit-05;

@include break-small () {
padding-right: $grid-unit-20 - ($grid-unit-15 * 0.5);
padding-right: $grid-unit-10;
}

gap: $grid-unit-10;
Expand Down
8 changes: 7 additions & 1 deletion packages/edit-site/src/components/header-edit-mode/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,13 @@ $header-toolbar-min-width: 335px;
.edit-site-header-edit-mode__actions {
display: inline-flex;
align-items: center;
padding-right: $grid-unit-10;
flex-wrap: nowrap;
padding-right: $grid-unit-05;

@include break-small () {
padding-right: $grid-unit-10;
}

gap: $grid-unit-10;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/interface/src/components/more-menu-dropdown/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

.interface-more-menu-dropdown__content .components-popover__content {
min-width: 280px;
min-width: 300px;

// Let the menu scale to fit items.
@include break-mobile() {
Expand Down
Loading