Social Icons: Add a 'Phone' icon which takes a tel: linkadded new phone variation #57125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds a new Phone variation to the Social Link block. It uses the DashIcons phone icon. It has a url attribute of 'tel:' so that users correctly add a phone phone number.
Why?
Issue: #55718
Its a nice addition to the social links block
How?
This adds a new Phone variation to the Social Link block. It uses the DashIcons phone icon. It has a url attribute of 'tel:' so that users correctly add a phone phone number.
Do note that because of the URL attribute, this variation is different than all other variations which have an empty URL. If the URL is empty we add an opacity to the icon to indicate to the user that they haven't added a URL yet. We also do not render Social Link Blocks on the front end if they have an empty URL. The phone icon's initial state in non-empty so works a little differently than the others.
Also, the block description from block.json isn't entirely appropriate in this context. ("Display an icon linking to a social media profile or site.") I'm not aware that we can alter that for a variation.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast